-
Notifications
You must be signed in to change notification settings - Fork 15.2k
[Clang][OpenMP] Add a util to implicitly map attach-ptr-exprs on target
, when applicable.
#161294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abhinavgaba
wants to merge
5
commits into
llvm:main
Choose a base branch
from
abhinavgaba:add-another-attach-helper-util-in-clang
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+150
−0
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f0cd9cd
Reuse the same comparator object for the same MEH.
abhinavgaba 08e051a
[NFC][Clang][OpenMP] Add a util to implicitly map `attach-ptr-exprs` …
abhinavgaba 117a718
Use getTypeSizeInChars
abhinavgaba 01c9fb1
Remove emitAttachEntry, and changes to OMPIRBuilder/OMPConstants.h
abhinavgaba 9dc785c
Merge remote-tracking branch 'origin/main' into add-another-attach-he…
abhinavgaba File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like it make it NFC, this is not NFC at all, and adding a new OMP_MAP_ATTACH too
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function is not called in this PR, which is what makes it an NFC. And since we are never adding the ATTACH map-type in this PR, the changes in OMPIRBuilder changes are also never triggered.
The reason to pull these changes out of the parent was just to help with the reviews.
If you don't think it's easier to review this as a subset, then please continue with reviewing the parent #153683, and this one can be closed.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, this really stretches the idea of NFC. This is large change, you adding members to a class, changing how other members are initialized etc. There is no loss in removing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was created after receiving feedback that it would be good to break the parent PR #153684 into smaller patches that can be merged independently. This is one such smaller patch. The NFC tag can be removed that causes concern/confusion.
There is no change in the output IR with this change alone. The parent PR is needed to change the output IR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the NFC tag, and removed the other util and the change to IRBUilder from this PR.