Revert "[bazel][mlir][python] Port #155741: stub auto-generation (#157173)" #157995
Conversation
…lvm#157173)" This reverts commit 46d8fdd. The whole set of commits got reverted in llvm#157831, reverting this one too.
Ahajha
requested review from
rupprecht,
keith and
aaronmondal
as code owners
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
|
For us, the downstream pyi files seemed to not actually be needed. Do you see breakage if the pyi files are missing? |
|
We run mypy on our python files, and removing the stubfiles does break things. I would prefer to just revert to how it was before since we'll have to integrate the stub generation into our build at a later point once it's relanded, and this avoids a temporary workaround. |
|
Ok, wanted to make sure this was actually breaking things. Otherwise it seemed the original changes were a nice dead code cleanup :) Sorry, I was out yesterday, otherwise I would have stamped sooner. |
|
@Ahajha Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
|
Yea I agree this will be nice to reland once the stubgen setup is working again. We use it internally and the generated stubs are super high quality. |
…ration" (#159940) Relands llvm/llvm-project#157173 (reverts llvm/llvm-project#157995). The stubgen was relanded here: llvm/llvm-project#157930
…llvm#159940) Relands llvm#157173 (reverts llvm#157995). The stubgen was relanded here: llvm#157930
…llvm#159940) Relands llvm#157173 (reverts llvm#157995). The stubgen was relanded here: llvm#157930
This reverts commit 46d8fdd.
The whole set of commits got reverted in #157831, reverting this one too.