Skip to content

[CloneFunction][DebugInfo] Ensure DILocalVariables of inlined functions are not cloned (NFC) #138590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

[CloneFunction][DebugInfo] Ensure DILocalVariables of inlined functions are not cloned (NFC) #138590

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions llvm/lib/Transforms/Utils/CloneFunction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,17 +59,28 @@ MetadataPredicate createIdentityMDPredicate(const Function &F,
return [](const Metadata *MD) { return false; };

DISubprogram *SPClonedWithinModule = F.getSubprogram();

// Don't clone inlined subprograms.
auto ShouldKeep = [SPClonedWithinModule](const DISubprogram *SP) -> bool {
return SP != SPClonedWithinModule;
};

return [=](const Metadata *MD) {
// Avoid cloning types, compile units, and (other) subprograms.
if (isa<DICompileUnit>(MD) || isa<DIType>(MD))
return true;

if (auto *SP = dyn_cast<DISubprogram>(MD))
return SP != SPClonedWithinModule;
return ShouldKeep(SP);

// If a subprogram isn't going to be cloned skip its lexical blocks as well.
if (auto *LScope = dyn_cast<DILocalScope>(MD))
return LScope->getSubprogram() != SPClonedWithinModule;
return ShouldKeep(LScope->getSubprogram());

// Avoid cloning local variables of subprograms that won't be cloned.
if (auto *DV = dyn_cast<DILocalVariable>(MD))
if (auto *S = dyn_cast_or_null<DILocalScope>(DV->getScope()))
return ShouldKeep(S->getSubprogram());

return false;
};
Expand Down