Skip to content

Conversation

YangKai0616
Copy link
Contributor

@YangKai0616 YangKai0616 commented Sep 23, 2025

Summary

Restored two passing test cases. Temporarily skipped three failing test cases to prevent CI errors.

Failed test cases require further investigation into the cause.

Test platform: Intel(R) Data Center GPU Max 1550
Test version: Torch 2.9.0a0+gitadae7f6 Triton:3.5.0+git9290e9a5

Testing Done

  • Hardware Type:
  • [√] run make test to ensure correctness
  • [√] run make checkstyle to ensure code style
  • [√] run make test-convergence to ensure convergence

@YangKai0616
Copy link
Contributor Author

@shimizust , please help review. Thx!

The CI error seems unrelated to this PR.

Copy link
Collaborator

@shimizust shimizust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YangKai0616 Thanks for resolving the intel ci issues. Can you create an issue to investigate the glm4v_moe issues?

@shimizust shimizust merged commit cf43acd into linkedin:main Sep 23, 2025
3 of 7 checks passed
@YangKai0616
Copy link
Contributor Author

@YangKai0616 Thanks for resolving the intel ci issues. Can you create an issue to investigate the glm4v_moe issues?

Sure! But I am bit busy these days, I'll wait until I figure out whether it's a XPU-Triton issue or something else before deciding which repo to create an issue in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants