Skip to content

[JSD] JSD fixes #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 14, 2025
Merged

[JSD] JSD fixes #609

merged 3 commits into from
Mar 14, 2025

Conversation

kashif
Copy link
Contributor

@kashif kashif commented Mar 14, 2025 •
edited
Loading

Summary

Fix the JSD to use the beta
made the triton kernel more stable by using the max-exp trick

  • Hardware Type:
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

austin362667
austin362667 approved these changes Mar 14, 2025
View reviewed changes
Copy link
Contributor

@austin362667 austin362667 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@lancerts lancerts merged commit 449f5cb into linkedin:main Mar 14, 2025
4 of 8 checks passed
@kashif kashif deleted the gkd-fix branch March 14, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@austin362667 austin362667 austin362667 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kashif @austin362667 @lancerts