Skip to content

Paligemma support #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 15, 2025
Merged

Paligemma support #608

merged 15 commits into from
Mar 15, 2025

Conversation

eljandoubi
Copy link
Contributor

Summary

This PR adds Paligemma support to the Liger-Kernel.

Testing Done

  • Hardware Type: RTX 3070
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

@eljandoubi
Copy link
Contributor Author

@lancerts Tests failed for reasons unrelated to the files changed.

@lancerts lancerts merged commit cc0c945 into linkedin:main Mar 15, 2025
4 of 8 checks passed
@eljandoubi
Copy link
Contributor Author

eljandoubi commented Mar 16, 2025 •
edited
Loading

@lancerts I made a mistake config.hidden_size does not match text_config.hidden_size. #612

@eljandoubi
Copy link
Contributor Author

@lancerts an other fix #613

@shivam15s shivam15s mentioned this pull request Mar 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lancerts lancerts lancerts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eljandoubi @lancerts