A few updates to the lint set #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having used
clippy::default_trait_accessas an editor lint, I'm really happy with it. It also only ever makes extremely local suggestions (making addressing it when writing a change trivial), and significantly improves readability in a lot of cases. It's also something which I've now found myself suggesting regularly in PR reviews, as better style.As such, I'm proposing that we move this into the proper lint set.
Separately,
unused_qualificationsis good for consistency (if you seeRectandkurbo::Rectnext to each other, you might reasonably assume that they are different types). As such, I'm also proposing that we move this into the "proper" lint set out of the periodic lints.This proposal is more marginal, and I'm happy to demote it back to a periodic lint if there's pushback.
Thirdly, I'm proposing removed the editor lints as a class; I don't think anyone ever used them, and the theory that you can make drive-by style fixes in otherwise unrelated PRs was never sound.