[EPIC] stVaults #874
Draft
[EPIC] stVaults #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: fb4f7e5 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
TheDZhon
reviewed
Nov 28, 2024
contracts/0.8.25/Accounting.sol
Outdated
| } | ||
|
|
||
| // Distribute protocol fee (treasury & node operators) | ||
| if (_update.sharesToMintAsFees > 0) { |
There was a problem hiding this comment.
this name might be misleading, should be named smth 'sharesToMintAsLidoV2ProtocolFees'
TheDZhon
reviewed
Nov 29, 2024
contracts/0.8.25/vaults/VaultHub.sol
Outdated
| import {AccessControlEnumerableUpgradeable} from "contracts/openzeppelin/5.0.2/upgradeable/access/extensions/AccessControlEnumerableUpgradeable.sol"; | ||
| import {IHubVault} from "./interfaces/IHubVault.sol"; | ||
| import {Math256} from "contracts/common/lib/Math256.sol"; | ||
| import {ILido as StETH} from "contracts/0.8.25/interfaces/ILido.sol"; |
There was a problem hiding this comment.
why this iface not in common?
There was a problem hiding this comment.
should revise iface structure in the future
contracts/0.8.25/vaults/VaultHub.sol
Outdated
|
|
||
| /// @notice disconnects a vault from the hub | ||
| /// @dev can be called by vaults only | ||
| function disconnectVault(address _vault) external { |
There was a problem hiding this comment.
let's add emergency flow
There was a problem hiding this comment.
let's consider the following cases:
- voluntary disconnect (this one)
- stop new minting
- eject and withdraw
- disconnect forcibly
There was a problem hiding this comment.
- disconnect and dust issue
folkyatina
reviewed
Nov 29, 2024
folkyatina
reviewed
Nov 29, 2024
folkyatina
reviewed
Nov 29, 2024
folkyatina
reviewed
Nov 29, 2024
contracts/0.8.25/vaults/VaultHub.sol
Outdated
| /// @notice force rebalance of the vault to have sufficient reserve ratio | ||
| /// @param _vault vault address | ||
| /// @dev can be used permissionlessly if the vault's min reserve ratio is broken | ||
| function forceRebalance(IHubVault _vault) external { |
There was a problem hiding this comment.
Embed auto-disconnect if resulting valuation is too small
folkyatina
reviewed
Nov 29, 2024
...acts/openzeppelin/5.0.2/upgradeable/access/extensions/AccessControlEnumerableUpgradeable.sol
Fixed
Show fixed
Hide fixed
...acts/openzeppelin/5.0.2/upgradeable/access/extensions/AccessControlEnumerableUpgradeable.sol
Fixed
Show fixed
Hide fixed
folkyatina
reviewed
Dec 3, 2024
folkyatina
reviewed
Dec 3, 2024
folkyatina
reviewed
Dec 3, 2024
Jeday
reviewed
Dec 5, 2024
Jeday
reviewed
Dec 5, 2024
Jeday
reviewed
Dec 5, 2024
tamtamchik
added
solidity
Merged
folkyatina
force-pushed
the
feat/vaults
branch
from
4af82f0 to
de33222
Compare
fix: review comments
[VAULTS] Audit fixes 2
Rework NodeOperatorFee
fix: prevent owner from lowering NO fee via unguaranteed deposit
…ate-topup [VAULTS] Improve PDG UX
[VAULTS] PDG side-activation
[VAULTS] Audit fixes 3
skhomuti
reviewed
Oct 1, 2025
| } | ||
|
|
||
| /** | ||
| * @dev Checks the confirming roles and sets the owner on the StakingVault. |
There was a problem hiding this comment.
the comment is not quite correct, it's better to copy the comment from public version of this method here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ 🚧 Under construction 🚧 ❗
Staking Vaults
New way of isolated staking, through separate vaults, with optional stETH liquidity