-
Notifications
You must be signed in to change notification settings - Fork 248
[VAULTS] Audit fixes 4 #1491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tamtamchik
wants to merge
53
commits into
feat/vaults
Choose a base branch
from
feat/audit-5
base: feat/vaults
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,081
−1,053
Open
[VAULTS] Audit fixes 4 #1491
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
4f45951
fix: update pause on connect to fix #1477
tamtamchik 1ddf60c
fix: apply resume to manual pause fix #1475
tamtamchik 7f9111f
feat: obligationsShortfallValue
tamtamchik 632baa2
chore: add new event
tamtamchik b93776a
chore: naming
tamtamchik 5c921dd
feat: draft for stakeLimit update
tamtamchik 3a38c5d
fix(VaultHub): limit connectVault to the owner of the vault
folkyatina a20b080
chore: introduce a constant for 31 ether
folkyatina 3309c0c
fix: add a SafeCast on internalization
folkyatina c3c83a0
feat: add vaultInfo function to lazyOracle
dry914 8f48435
feat: add tests and fix the code
tamtamchik ca9d5e1
test(stakingLimit): add unit and fuzzing tests
tamtamchik 5f988b1
chore: naming and simplify
tamtamchik 97cbdb0
chore: fix comments
tamtamchik b921ad5
fix: remove redundant errror
dry914 cc7ef3d
chore: rename vaultInfo func
dry914 3d55079
Merge pull request #1490 from lidofinance/feat/view-vault-info
tamtamchik 8cf2746
Merge pull request #1488 from lidofinance/feat/fix-staking-limit
tamtamchik cb5a960
chore: fixes after review
tamtamchik 06ad2c1
Merge pull request #1487 from lidofinance/feat/expose-shortfall
tamtamchik b090c27
Merge branch 'feat/audit-5' into feat/fix-pause
tamtamchik e1c7f7d
chore: review
tamtamchik f1e00ec
chore: updates after review
tamtamchik d726f91
fix: integration tests
tamtamchik 06ff85e
docs: more clarity for annual balance sanity check
folkyatina e2d48cd
Merge pull request #1484 from lidofinance/feat/fix-pause
tamtamchik ac68c5c
fix(StETH): check uint128 overflow on share mint
folkyatina bdb71a9
chore: more intuitive constants in UnstructuredStorageExt
folkyatina d9878f3
chore: optimize VaultHub bytecode
folkyatina 92a32d7
docs(Dashboard): improve comments
folkyatina 3a99ddc
chore: update rights for ET contracts
dry914 727bbb0
fix(Lido): make staking pause/resume revert if paused/resumed
folkyatina 516f7e8
fix(Lido): simplify the pause check
folkyatina 2ec78d2
Merge pull request #1489 from lidofinance/fix/vaulthub-polish
folkyatina 863eeb8
Merge pull request #1493 from lidofinance/fix/revertable-staking-pause
folkyatina 8d4265f
fix(PDG): fix reentrancy path in PDG
folkyatina 66d902f
chore(PDG): fix indentation
folkyatina 5af1280
fix: upgrade after TW went live on mainnet
arwer13 4f252fc
chore: merge deployed-mainnet.json from develop
arwer13 55c7e33
fix: more tidying up for V3VoteScript.sol
arwer13 6e7aac5
fix: #1476
tamtamchik 294fd95
Merge remote-tracking branch 'origin/fix/upgrade-after-tw' into feat/…
tamtamchik e66be55
Merge pull request #1496 from lidofinance/fix/upgrade-after-tw
arwer13 482a944
Merge pull request #1492 from lidofinance/feat/update-et-rights
arwer13 dd3312d
Merge branch 'feat/audit-5' into feat/fix-1476
tamtamchik c978a2e
chore: fixes after review
tamtamchik ed1d5d8
Merge pull request #1495 from lidofinance/fix/pdg-reentrancy
folkyatina c7320bb
fix: overflow in node operator fee
folkyatina a9091e2
docs(PDG): more comments
folkyatina 8f8b86a
Merge pull request #1500 from lidofinance/fix/no-fees-overflow
folkyatina 1da30f1
chore: probably better branching
tamtamchik 12acdb5
docs(VaultHub): clarify EIP-7002 withdrawal fee
folkyatina 88ce964
Merge pull request #1498 from lidofinance/feat/fix-1476
TheDZhon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.