Skip to content

[Bug]: Owner decreasing NodeOperator fee by performing unguaranteed deposits to own validator with different WC #1421

@failingtwice

Description

@failingtwice

Summary

unguaranteedDepositToBeaconChain increases rewards adjustment _setRewardsAdjustment(rewardsAdjustment.amount + totalAmount).

The vault's owner can submit his own validators that he controls, they can already be initialised and have deffierent WC, fully controlled by the vault's owner. It doesn't seem like a big deal, these validator's won't be added by the oracle to the total value of the vault.

The problem is that the _setRewardsAdjustment(rewardsAdjustment.amount + totalAmount) will still happen, so the owner can just easily increase rewardsAdjustment.amount by any value he wants, essentially avoid payign fees to the NO.

Expected Behavior

Vault owner cannot decrease NodeOperator fees

Potential Impact

NodeOperator losing fees

Steps to Reproduce

  • perform unguaranteed deposit from vault owner to a different WC
  • adjustment is increased
  • NodeOperator loses fees

Possible Solutions

No response

Guidelines

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions