Skip to content

Conversation

rengolin
Copy link
Contributor

No description provided.

@rengolin rengolin requested a review from Copilot March 11, 2025 13:50
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds a new GitHub Actions workflow that runs CI tests on an Arm Graviton3 instance.

  • Adds a new workflow file to configure and run tests on a Graviton3 instance via EC2
  • Sets up AWS credentials and starts an EC2 instance before triggering build and benchmark scripts

@rengolin rengolin added the arm Test on Arm machines label Mar 11, 2025
@rengolin rengolin requested review from adam-smnk and arun-thmn March 11, 2025 14:07
@rengolin
Copy link
Contributor Author

@adam-smnk, the script works 99%. The only problem is that when the tests fail, the benchmark still runs (which is good) but the test passes (which is bad). I'll change the script to fail on check.

@arun-thmn, one of your tests is failing. I'm assuming it has something to do with AVX vs SVE.

@rengolin rengolin added benchmark-full Benchmark all targets and removed arm Test on Arm machines labels Mar 11, 2025
@rengolin rengolin added arm Test on Arm machines and removed benchmark-full Benchmark all targets labels Mar 11, 2025
@arun-thmn
Copy link
Contributor

@rengolin Thanks. I will take a look into it.

@rengolin
Copy link
Contributor Author

@rengolin Thanks. I will take a look into it.

Thanks! I have moved this to a new issue (#1021), so we can merge this and use the new Arm builder to start fixing the BF16 tests.

@rengolin
Copy link
Contributor Author

@adam-smnk this should be good to merge, we can fix the test later.

@rengolin rengolin merged commit 75ad1e2 into main Mar 11, 2025
21 checks passed
@rengolin rengolin deleted the graviton-ci branch March 11, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Test on Arm machines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants