Implement Stash API.

[Therzok]

Based on libgit2/libgit2#2705

Not in master yet, adding so I can test locally.

[nulltoken]

ZOMG! tabs!

[Therzok]

Yeah, I know. I did it as fast as possible without caring what's going on. :P

[nulltoken]

😉

[vbjay]

https://visualstudiogallery.msdn.microsoft.com/dbcb8670-889e-4a54-a226-a48a15e4cace --2013
https://visualstudiogallery.msdn.microsoft.com/3a96a4dc-ba9c-4589-92c5-640e07332afd --2012
https://visualstudiogallery.msdn.microsoft.com/d0d33361-18e2-46c0-8ff2-4adea1e34fef --2010

All have the feature to detect mixed tabs.

https://visualstudiogallery.msdn.microsoft.com/c8bccfe2-650c-4b42-bc5c-845e21f96328 This one saves your bacon by changing the settings to fit the design of which project you are on.

[Therzok]

@vbjay I do my work in XS and it has auto-format on save, I just didn't do it in an IDE this time (vimmed my way through it since I was ssh'ing to my machine from college when this PR happened).

[vbjay]

Oh the fun with vim. :)

On Wed Dec 03 2014 at 11:33:17 AM Marius Ungureanu [email protected]
wrote:

@vbjay https://github.com/vbjay I do my work in XS and it has
auto-format on save, I just didn't do it in an IDE this time (vimmed my way
through it since I was ssh'ing to my machine from college when this PR
happened).

—
Reply to this email directly or view it on GitHub
#871 (comment).

[txdv]

Use "Show invisible chars"

[Therzok]

Hey guys, I really mentioned "I wanted a quick patch" to test. I opened the PR on API discussion. I'll fix the PR up after the libgit2 PR is merged, since there's no worth in overworking if that PR is dropped or the API changes. 🐰

[nulltoken]

@Therzok spaces are a serious matter. That shouldn't be underestimated. Ever

[Therzok]

Okay, I'm advancing on this thing.

I got a few issues I have to point out.

• This won't build on travis until we have that PR merged into upstream.
• Stash apply libgit2#3018 (comment) - I'm testing this specific behavior.
• Conflicts don't appear in the index for some reason. I'm an idiot who can't read docs x100.
• Test coverage is horrible. 💃

[Therzok]

I'm also experiencing some weird behaviour:

• If I use ReinstateIndex, I get the new changes in the workdir.
• Something screwed up (I updated GitCheckoutOpts, I probably missed something else?) I'm getting Invalid version 2049 on git_checkout_options).
• No intermediary updates. :D

[Therzok]

Probably this could be abstracted in a StashApplyOptions.

class StashApplyOptions
{
    StashApplyModifiers flags;
    CheckoutOptions checkoutOptions;
}

/cc @nulltoken