Skip to content

Conversation

theHocineSaad
Copy link
Contributor

Solves #659

image image

Copy link
Member

@driesvints driesvints left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for submitting! I gave this a quick glance and left a small bit of feedback.

<a href="#api_token_settings_heading" class="text-gray-600 hover:bg-gray-50 hover:text-gray-900 flex items-center px-3 py-2 text-sm font-medium rounded-md">
<a href="#github_settings_heading"
class="text-gray-600 hover:bg-gray-50 hover:text-gray-900 flex items-center px-3 py-2 text-sm font-medium rounded-md">
<x-icon-github-line class="text-gray-400 shrink-0 -ml-1 mr-3 h-6 w-6" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just re-use the GitHub icon from simple-icons here that's also used in other places on the site?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not in the same style as the other icons, that's why I didn't use it.

Simple icons <x-si-github/>
image

The icon I added (the closest in style that I could find):
image

@theHocineSaad theHocineSaad marked this pull request as draft October 9, 2025 12:32
@theHocineSaad theHocineSaad marked this pull request as ready for review October 9, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants