Skip to content

Conversation

dylanmichaelryan
Copy link
Contributor

@dylanmichaelryan dylanmichaelryan commented Feb 24, 2025

Github doesn't provide a last name.


For more details, open the Copilot Workspace session.

Github doesn't provide a last name.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/laravel/workos?shareId=XXXX-XXXX-XXXX-XXXX).
@hubertkoy
Copy link

same with first name @dylanmichaelryan

I would suggest to allow first name of being nullable

?

if both null then name = email?

@dylanmichaelryan
Copy link
Contributor Author

@hubertkoy

Oh yes, probably if you don't have a name set at all. I think the first and last name fields are optional with WorkOS, so maybe
nulling both of them is good enough?

@hubertkoy
Copy link

Well yeah, that should do the job now, only issue people can have it's when both being null, and you trying create user where by default name in User Model it's not null they still would have exception

@taylorotwell taylorotwell merged commit 1779062 into laravel:main Feb 25, 2025
6 of 7 checks passed
@inmanturbo inmanturbo mentioned this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants