Skip to content

[0.x] Adds support for custom request classes #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 24, 2025
Merged

[0.x] Adds support for custom request classes #63

merged 4 commits into from
Sep 24, 2025

Conversation

nunomaduro
Copy link
Member

No description provided.

nunomaduro
nunomaduro commented Sep 24, 2025
View reviewed changes
Copy link
Member Author

@nunomaduro nunomaduro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fully tested.

@nunomaduro nunomaduro marked this pull request as ready for review September 24, 2025 05:23
ashleyhindle
ashleyhindle reviewed Sep 24, 2025
View reviewed changes
ashleyhindle
ashleyhindle reviewed Sep 24, 2025
View reviewed changes
ashleyhindle
ashleyhindle approved these changes Sep 24, 2025
View reviewed changes
Copy link
Collaborator

@ashleyhindle ashleyhindle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 💪 Not sure if there's a cleaner way of passing data from the 'base' request to the custom request, but this works well 👌

One question re: $tool->handle() vs Container::make(Resource)->call('handle') (or similar) - should they behave differently?

@taylorotwell taylorotwell merged commit 0ecf0c0 into main Sep 24, 2025
18 checks passed
@taylorotwell taylorotwell deleted the feat/support-for-custom-request branch September 24, 2025 15:48
@ashleyhindle ashleyhindle mentioned this pull request Sep 29, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyhindle ashleyhindle ashleyhindle approved these changes

@taylorotwell taylorotwell Awaiting requested review from taylorotwell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nunomaduro @ashleyhindle @taylorotwell