Add PHPUnit 12 compatibility while maintaining backwards compatibility #1576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add PHPUnit 12 to version constraints in composer.json - Update phpstan to support version 2.0 - Update predis to support version 3.0 - Add cacheDirectory attribute for PHPUnit 10+ (ignored by PHPUnit 9) - Keep all existing attributes for backwards compatibility - Update .gitignore to exclude PHPUnit cache directory - No schema reference to avoid validation conflicts between versions This allows the package to work with PHPUnit 9, 10, 11, and 12.
Removed the following deprecated attributes that cause warnings in PHPUnit 12: - backupStaticAttributes - convertDeprecationsToExceptions - convertErrorsToExceptions - convertNoticesToExceptions - convertWarningsToExceptions - verbose These attributes are no longer needed and their removal maintains compatibility with PHPUnit 9-12 while eliminating warnings in PHPUnit 12.
Add command-line flags to maintain the same test behavior after removing deprecated XML attributes: - --fail-on-risky (replaces failOnRisky attribute) - --fail-on-warning (replaces failOnWarning attribute) - --stop-on-error (replaces stopOnError attribute) - --stop-on-failure (replaces stopOnFailure attribute) - --display-warnings/errors/notices/deprecations (replaces convert* attributes) This ensures tests maintain the same strictness level across all PHPUnit versions.
Remove non-existent --display-* flags. The convert* XML attributes that were removed actually control PHP error handling, which is handled by PHPUnit's default behavior. Keep only the flags that exist and maintain test strictness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the package to work with PHPUnit 9, 10, 11, and 12.