Skip to content

Make $user = null the default in viewHorizon gate closure for better DX #1554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 14, 2025
Merged

Make $user = null the default in viewHorizon gate closure for better DX #1554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4c550e
Make $user = null the default in viewHorizon gate closure for better DX
mitoop May 14, 2025
70d9d66
add optional
mitoop May 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stubs/HorizonServiceProvider.stub
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ class HorizonServiceProvider extends HorizonApplicationServiceProvider
*/
protected function gate(): void
{
Gate::define('viewHorizon', function ($user) {
return in_array($user->email, [
Gate::define('viewHorizon', function ($user = null) {
return in_array(optional($user)->email, [
//
]);
});
Expand Down