[12.x] Use Container::getInstance() in ComposerScripts::prePackageUninstall()
#57226
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: htulibacki <[email protected]>
cosmastech
force-pushed
the
fix-composer-script
branch
from
348354f to
85da0ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relying on the result of
require_oncedoesn't work if multiple packages are being uninstalled 😓require_oncereturns true the second time it's called (TIL).Instead, we leverage
Container::getInstance()and live happily ever after. 🤞See discussion: #57220
Thanks to @htulibacki for reporting this and helping test.