Skip to content

[12.x] Remove unnecessary parentheses #57212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2025
Merged

[12.x] Remove unnecessary parentheses #57212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions tests/Database/DatabaseTransactionsManagerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ class DatabaseTransactionsManagerTest extends TestCase
{
public function testBeginningTransactions()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);
$manager->begin('default', 2);
Expand All @@ -26,7 +26,7 @@ public function testBeginningTransactions()

public function testRollingBackTransactions()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);
$manager->begin('default', 2);
Expand All @@ -45,7 +45,7 @@ public function testRollingBackTransactions()

public function testRollingBackTransactionsAllTheWay()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);
$manager->begin('default', 2);
Expand All @@ -61,7 +61,7 @@ public function testRollingBackTransactionsAllTheWay()

public function testCommittingTransactions()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);
$manager->begin('default', 2);
Expand Down Expand Up @@ -90,7 +90,7 @@ public function testCallbacksAreAddedToTheCurrentTransaction()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);

Expand All @@ -111,7 +111,7 @@ public function testCallbacksAreAddedToTheCurrentTransaction()

public function testCallbacksRunInFifoOrder()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$order = [];

Expand All @@ -138,7 +138,7 @@ public function testCommittingTransactionsExecutesCallbacks()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);

Expand Down Expand Up @@ -166,7 +166,7 @@ public function testCommittingExecutesOnlyCallbacksOfTheConnection()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);

Expand All @@ -192,7 +192,7 @@ public function testCallbackIsExecutedIfNoTransactions()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->addCallback(function () use (&$callbacks) {
$callbacks[] = ['default', 1];
Expand All @@ -206,7 +206,7 @@ public function testCallbacksForRollbackAreAddedToTheCurrentTransaction()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);

Expand All @@ -229,7 +229,7 @@ public function testRollbackTransactionsExecutesCallbacks()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);

Expand Down Expand Up @@ -257,7 +257,7 @@ public function testRollbackExecutesOnlyCallbacksOfTheConnection()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);

Expand All @@ -283,7 +283,7 @@ public function testCallbackForRollbackIsNotExecutedIfNoTransactions()
{
$callbacks = [];

$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->addCallbackForRollback(function () use (&$callbacks) {
$callbacks[] = ['default', 1];
Expand All @@ -294,7 +294,7 @@ public function testCallbackForRollbackIsNotExecutedIfNoTransactions()

public function testStageTransactions()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);
$manager->begin('admin', 1);
Expand Down Expand Up @@ -323,7 +323,7 @@ public function testStageTransactions()

public function testStageTransactionsOnlyStagesTheTransactionsAtOrAboveTheGivenLevel()
{
$manager = (new DatabaseTransactionsManager);
$manager = new DatabaseTransactionsManager;

$manager->begin('default', 1);
$manager->begin('default', 2);
Expand Down