Skip to content

Conversation

daniser
Copy link
Contributor

@daniser daniser commented Sep 24, 2025

=== have higher precedence than ??, hence false === true always return false.
Logic is unaffected by this PR, just a small cosmetical fix to avoid confusion.

@browner12
Copy link
Contributor

browner12 commented Sep 24, 2025

this does change behavior slightly because we are currently looking for strict equality. this change would allow any truthy value in the config to enable the read only class.

edit: ooh scratch that, I see what you're saying, I think you're right.

@daniser
Copy link
Contributor Author

daniser commented Sep 24, 2025

this does change behavior slightly because we are currently looking for strict equality. this change would allow any truthy value in the config to enable the read only class.

Okay, I'll fix that, but there never been strict equality before because false === true is false.

@taylorotwell
Copy link
Member

Fixed.

@browner12
Copy link
Contributor

to be clear, I think you were right @daniser and IMO this should have been merged.

@daniser
Copy link
Contributor Author

daniser commented Sep 24, 2025

@browner12 I think Taylor already fixed this by applying grouping.

browner12 referenced this pull request Sep 24, 2025
@browner12
Copy link
Contributor

@daniser as I showed in my comment on Taylor's commit, his commit actually changed behavior while yours did not. I'd resubmit this with that explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants