[12.x] Replace logger helper and log function concrete return type ?LogManager with abstract ?LoggerInterface #57028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
|
I'll just add my two cents and say we were having the same issue. Came from a separate library (LogFake), but this would resolve the issue I was having. |
…ith ?LoggerInterface
abdelrahmenAyman
force-pushed
the
fix-logger-helper-concrete-return-type
branch
from
a4ac716 to
9973737
Compare
|
@crynobone This should be ready now! |
tegos
pushed a commit
to tegos/laravel-framework
that referenced
this pull request
Sep 28, 2025
…ith ?LoggerInterface (laravel#57028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
Change helper function
loggerreturn type to?LoggerInterfaceinstead of?LoggerManager.LoggerManagerimplementsLoggerInterface, which means any code expecting aLogManagershould still work fine since this is the wider type.Motivation
The return type was introduced in a recent PR #56684 . Introducing the change to our codebase broke multiple tests where we mocked the logger function using a
LoggerInterfacemock instance.Programming for interfaces is a widely accepted practice in the industry, thus the function should be returning an Interface instead of a concrete type to be flexible enough for any more logger classes in the future.