Skip to content

[12.x] Allow strict integer validation #56503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 3, 2025
Merged

[12.x] Allow strict integer validation #56503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/Illuminate/Validation/Concerns/ValidatesAttributes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1554,10 +1554,15 @@ public function validateInArrayKeys($attribute, $value, $parameters)
*
* @param string $attribute
* @param mixed $value
* @param array{0: 'strict'} $parameters
* @return bool
*/
public function validateInteger($attribute, $value)
public function validateInteger($attribute, $value, array $parameters)
{
if (($parameters[0] ?? null) === 'strict') {
return is_int($value);
}

return filter_var($value, FILTER_VALIDATE_INT) !== false;
}

Expand Down
22 changes: 22 additions & 0 deletions tests/Validation/ValidationValidatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3283,6 +3283,28 @@ public function testValidateInteger()
$this->assertTrue($v->passes());
}

public function testValidateIntegerStrict()
{
$trans = $this->getIlluminateArrayTranslator();
$v = new Validator($trans, ['foo' => 'asdad'], ['foo' => 'Integer:strict']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => '1.23'], ['foo' => 'Integer:strict']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => '-1'], ['foo' => 'Integer:strict']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => '1'], ['foo' => 'Integer:strict']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 0.1], ['foo' => 'Integer:strict']);
$this->assertFalse($v->passes());

$v = new Validator($trans, ['foo' => 1], ['foo' => 'Integer:strict']);
$this->assertTrue($v->passes());
}

public function testValidateDecimal()
{
$trans = $this->getIlluminateArrayTranslator();
Expand Down
Loading