[12.x] Standardize size() behavior and add extended queue metrics support #56010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…served size and oldest job where available. Add the new metrics to the monitor command output. Update the QueueFake driver to support testing delayed jobs and reserved jobs.
The size method now follows the convention of all other drivers where size() returns the total number of jobs and not just pending jobs
Remove redundant int casts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves queue metric support by adding methods to retrieve:
It also fixes inconsistencies in the
size()method. Previously, different queue drivers returned different values — some only counted pending jobs, while others included all jobs.Now,
size()consistently returns the total number of jobs (pending + delayed + reserved) across all supported drivers.Previous behavior:
size()Beforesize()Now--maxbehavior inqueue:monitorThe
--maxoption currently uses thesize()method to determine when to trigger alerts.Since
size()now consistently returns the total job count (pending + delayed + reserved), this may lead to different behavior compared to earlier versions — especially if delayed or reserved jobs are significant.In most cases, it's more meaningful to base alerts on pending jobs only.
This PR does not change how
--maxworks, but it may be worth considering updatingqueue:monitorto optionally usesizePending()instead.🧪 Testing Improvements
The
FakeQueuehas been updated to support testing of job state transitions:pending,delayed, andreserved