[12.x] Add a command option for making batchable jobs #55929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plytas
reviewed
Jun 10, 2025
| */ | ||
| public function handle(): void | ||
| { | ||
| if ($this->batch()->cancelled()) { |
There was a problem hiding this comment.
Correct me if I'm wrong. Just because a job can be batched, doesn't necessarily mean that it will be batched. It's possible that it can be dispatched to the queue on it's own. In that case $this->batch() will return null.
Suggested change
| if ($this->batch()->cancelled()) { | |
| if ($this->batch()?->cancelled()) { |
This was referenced Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
--batchedoption tomake:jobcommand to make batchable jobs: