feat(js): retrieval/integration doc translations #692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
langchain
|
Preview ID generated: preview-hunter-1759195386-b13f72a |
hntrl
force-pushed
the
hunter/js-retrieval
branch
from
66de32b to
ad39b30
Compare
|
Preview ID generated: preview-hunter-1759269798-fb6d734 |
|
Preview ID generated: preview-hunter-1759270187-c8de940 |
lnhsingh
reviewed
Oct 1, 2025
| print(texts[0]) | ||
| ``` | ||
| ```output | ||
| page_content='Madam Speaker, Madam Vice President, our First Lady and Second Gentleman. Members of Congress and the Cabinet. Justices of the Supreme Court. My fellow Americans. \n\nLast year COVID-19 kept us apart. This year we are finally together again. \n\nTonight, we meet as Democrats Republicans and Independents. But most importantly as Americans. \n\nWith a duty to one another to the American people to the Constitution. \n\nAnd with an unwavering resolve that freedom will always triumph over tyranny. \n\nSix days ago, Russia’s Vladimir Putin sought to shake the foundations of the free world thinking he could make it bend to his menacing ways. But he badly miscalculated. \n\nHe thought he could roll into Ukraine and the world would roll over. Instead he met a wall of strength he never imagined. \n\nHe met the Ukrainian people. \n\nFrom President Zelenskyy to every Ukrainian, their fearlessness, their courage, their determination, inspires the world.' |
There was a problem hiding this comment.
Ideally, we'd have output/examples that are non-political and not American-centric to make our docs more accessible to a wider audience, but I think stateOfTheUnion was an existing example already. Just flagging - we can update this example later
There was a problem hiding this comment.
yeah these are brought over
eyurtsev
approved these changes
Oct 1, 2025
| :::js | ||
| ```typescript | ||
| import { createAgent } from "langchain"; | ||
| import { createAgent, dynamicSystemPromptMiddleware } from "langchain"; |
There was a problem hiding this comment.
@christian-bromann are we removing this prebuilt middleware in favor of modifyRequest?
There was a problem hiding this comment.
no, we decided to keep dynamicSystemPromptMiddleware in JS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.