chore(helm): add rbac unit-tests for istio sources #5752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ivan katliarchuk <[email protected]>
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
troll-os
pushed a commit
to FiligranHQ/external-dns
that referenced
this pull request
Aug 28, 2025
) Signed-off-by: ivan katliarchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
Adds RBAC tests for istio sources.
I think the code already have
singleflighthttps://github.com/kubernetes-sigs/external-dns/blob/master/source/wrappers/dedupsource.go. Unless I misunderstood the idea.The problem I see at the moment,
istio-virtualserviceactually fully duplicates some of theistio-gatewaylogic withingresses. So we may need to consider cleanup in the futureistio-virtualserviceMotivation
#5743 (comment)
More