Skip to content

fix(rbac): conditional endpointslices perms #5746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

fix(rbac): conditional endpointslices perms #5746

merged 1 commit into from
Aug 19, 2025

Conversation

vflaux
Copy link
Contributor

@vflaux vflaux commented Aug 18, 2025

What does it do ?

  • Only grant endpointslices RBAC when service source is used in chart.
  • Removes unneeded v1/endpoints permissions in godaddy & ovh tutorials.

Motivation

We grant endpointslices permissions when not needed in the helm chart. If I'm not mistaken, only the service source use endpointslices.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 18, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added chart docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@ivankatliarchuk
Copy link
Contributor

can we add helm unit tests as well?

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 19, 2025
stevehipwell
stevehipwell suggested changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @vflaux, could you please add an entry to the chart CHANGELOG?

@vflaux vflaux force-pushed the endpointslices_clusterroles branch from f2e6bd8 to 26bc061 Compare August 19, 2025 11:12
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2025
stevehipwell
stevehipwell reviewed Aug 19, 2025
View reviewed changes
@vflaux
fix(chart/rbac): conditional endpointslices perms and cleanup depreca…
de30762 
…ted endpoints

Only grant endpointslices permissions when using service source and remove
outdated endpoints RBAC from provider tutorials.
Add rbac tests for the chart.
@vflaux vflaux force-pushed the endpointslices_clusterroles branch from 99068aa to de30762 Compare August 19, 2025 11:16
@stevehipwell
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 19, 2025
@ivankatliarchuk
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@k8s-ci-robot k8s-ci-robot merged commit 8950e7d into kubernetes-sigs:master Aug 19, 2025
15 checks passed
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
@vflaux @troll-os
fix(chart/rbac): conditional endpointslices perms and cleanup depreca…
eb0ba08 
…ted endpoints (kubernetes-sigs#5746)

Only grant endpointslices permissions when using service source and remove
outdated endpoints RBAC from provider tutorials.
Add rbac tests for the chart.
@vflaux vflaux deleted the endpointslices_clusterroles branch September 10, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szuecs szuecs Awaiting requested review from szuecs

1 more reviewer

@stevehipwell stevehipwell stevehipwell requested changes

Reviewers whose approvals may not affect merge requirements
Assignees

@stevehipwell stevehipwell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. chart cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. docs lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vflaux @k8s-ci-robot @ivankatliarchuk @stevehipwell