feat(source): support --event flags with sources pod and node #5642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
source
size/M
|
Hi @xiangyanw Can you confirm that this PR fixes your issue. If needed, see how to test a PR ?. This will require golang to be installed. |
ivankatliarchuk
force-pushed
the
feat-pod-support-events
branch
from
477bb18 to
7019d79
Compare
k8s-ci-robot
added
size/L
Signed-off-by: ivan katliarchuk <[email protected]>
ivankatliarchuk
force-pushed
the
feat-pod-support-events
branch
from
7019d79 to
7d40c25
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
troll-os
pushed a commit
to FiligranHQ/external-dns
that referenced
this pull request
Aug 28, 2025
…etes-sigs#5642) Signed-off-by: ivan katliarchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
--eventflag to work with sourcesPod
event handlernot required nodeinformer. If there going to be a use case, we could addnodeinformerevents handling as well.Motivation
Fixes #5274
More