fix(source/service): disable node informer when not required #5613
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
source
size/L
…s activated Signed-off-by: ivan katliarchuk <[email protected]> fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]>
ivankatliarchuk
force-pushed
the
feat-disable-node-informer-service-3169
branch
from
8fda513 to
f1dd912
Compare
|
Hi @iameli. Not sure if you still interested in the fix. But if yes, can you confirm that this PR fixes your issue. If needed, see how to test a PR ?. This will require golang to be installed. |
mloiseleur
reviewed
Jul 9, 2025
…s activated Co-authored-by: Michel Loiseleur <[email protected]>
…s activated Signed-off-by: ivan katliarchuk <[email protected]>
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
3 tasks
troll-os
pushed a commit
to FiligranHQ/external-dns
that referenced
this pull request
Aug 28, 2025
…tes-sigs#5613) * fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> * fix(source/service): disable node informer when service type filter is activated Co-authored-by: Michel Loiseleur <[email protected]> * fix(source/service): disable node informer when service type filter is activated Signed-off-by: ivan katliarchuk <[email protected]> --------- Signed-off-by: ivan katliarchuk <[email protected]> Co-authored-by: Michel Loiseleur <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do ?
--service-type-filteris configured, disable node informer when not requirednodeInformerused in 2 placesv1.ServiceTypeNodePort(could be safely disabled)V1. ServiceTypeClusterIP-> added null check, and warning message, so that if informer is disabled but should be enabledMotivation
Fixes #3169
Follow-up:
--service-type-filteris specified. This should increase performance and reduce number of API calls and etc.More