Skip to content

Conversation

mloiseleur
Copy link
Collaborator

What does it do ?

Automatically set a label on each root directory

Motivation

Follow-up of #5481.
Easier PR review / triage.

More

  • Yes, this PR title follows Conventional Commits
  • Yes, I added unit tests
  • Yes, I updated end user documentation accordingly

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 27, 2025
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 27, 2025
@ivankatliarchuk
Copy link
Contributor

The filters in global file should just work

filters:
  "controller$":
    labels:
    -controller
  "source$":
      labels:
      -source

Example from kubernetes https://github.com/kubernetes/kubernetes/blob/6ed5b60f71930d51bfcf8bfa6f3506b099811318/OWNERS#L4

@AndrewCharlesHay
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2025
@mloiseleur
Copy link
Collaborator Author

mloiseleur commented Jul 3, 2025

The filters in global file should just work

filters:
  "controller$":
    labels:
    -controller
  "source$":
      labels:
      -source

Example from kubernetes https://github.com/kubernetes/kubernetes/blob/6ed5b60f71930d51bfcf8bfa6f3506b099811318/OWNERS#L4

@ivankatliarchuk It does not work when labels are sets with sub OWNERS file. We are in this case, mainly for the Chart.
That's why I opened previous PR, #5481, some labels were configured and not applied.

@mloiseleur
Copy link
Collaborator Author

@ivankatliarchuk I'll let you merge this PR or leave me an other comment if you think there is a better way.

Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot merged commit fc4a2cb into kubernetes-sigs:master Jul 3, 2025
15 checks passed
troll-os pushed a commit to FiligranHQ/external-dns that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants