-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(rfc2136): Use correct index for accessing UpdateOld if there are multiple chunks #5542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @schwajo! |
Hi @schwajo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@schwajo You need to sign the CLA before we can review this PR. |
/ok-to-test |
d3936da
to
3a7ebf9
Compare
f5ccaa0
to
25bf7d1
Compare
/lgtm |
@joshlreese @Jeremy-Boyle Wdyt of this PR ? Do you think you can review it ? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mloiseleur The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
If there are many updates to be made, UpdateNew is split into several chunks.
To get the corresponding row in UpdateOld, only the index in the current chunk is used.
But UpdateOld is not splitted, to get the right element in UpdateOld (not splitted), you have to adjust the index to be in the corresponding chunk.
More