-
Notifications
You must be signed in to change notification settings - Fork 2.8k
fix(chart): release chart workflow #5533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Welcome @Bartosz-lab! |
Hi @Bartosz-lab. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test cc: @stevehipwell |
.github/workflows/release-chart.yaml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Install YQAdd commentMore actions | |
- name: Install YQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to remove the whitespace on line 31.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@Bartosz-lab thanks for the PR. As well as the fixes suggested above could you please also update the Chart.yaml file to trigger a re-run of the release. My suggestion is to add |
Signed-off-by: Bartosz Cieślik <[email protected]>
/lgtm |
@mloiseleur please could you approve this PR? |
/assign @mloiseleur |
/retitle fix(chart): release chart workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivankatliarchuk, stevehipwell The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What does it do ?
This PR fixes unsuccessful chart release.
Workflow for release v0.17.0 of helm chart failed.
See Release Chart GH Action
closes #5398
More