Skip to content

chore(cloudflare): move regional services logic to dedicated file #5329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2025
Merged

chore(cloudflare): move regional services logic to dedicated file #5329

merged 2 commits into from
May 23, 2025
+602 −523

Conversation

vflaux
Copy link
Contributor

@vflaux vflaux commented Apr 25, 2025 •
edited
Loading

This PR is a subpart of #5309.

Description

Start moving some regional services logic to a dedicated file.

  • Rename DataLocalizationRegionalHostnameChange to RegionalHostnameChange
  • Move the creation of RegionalHostname into a dedicated function, replacing getRegionKey()

Checklist

  • Unit tests updated
  • End user documentation updated

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2025
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @vflaux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 25, 2025
@vflaux vflaux mentioned this pull request Apr 25, 2025
Merged
2 tasks
@ivankatliarchuk
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2025
@mloiseleur
Copy link
Collaborator

It's clearly a simple move + an helper func.
Thanks @vflaux 👍
/retitle chore(cloudflare): move regional services logic to dedicated file
/lgtm
@ivankatliarchuk @mrozentsvayg any comments before we merge this PR ?

@k8s-ci-robot k8s-ci-robot changed the title cloudflare: move some regional services logic to dedicated file chore(cloudflare): move regional services logic to dedicated file Apr 26, 2025
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2025
ivankatliarchuk
ivankatliarchuk suggested changes Apr 27, 2025
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 27, 2025
ivankatliarchuk
ivankatliarchuk reviewed Apr 27, 2025
View reviewed changes
ivankatliarchuk
ivankatliarchuk suggested changes Apr 27, 2025
View reviewed changes
@vflaux vflaux force-pushed the cf_improve_regional_hostname_1 branch from a4f8a73 to 2a63520 Compare April 28, 2025 02:25
ivankatliarchuk
ivankatliarchuk approved these changes Apr 28, 2025
View reviewed changes
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2025
mrozentsvayg
mrozentsvayg reviewed Apr 29, 2025
View reviewed changes
@ivankatliarchuk
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 29, 2025
@vflaux vflaux force-pushed the cf_improve_regional_hostname_1 branch from 2a63520 to 750dffb Compare May 5, 2025 23:51
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2025
ivankatliarchuk
ivankatliarchuk approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@ivankatliarchuk ivankatliarchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2025
@mloiseleur
Copy link
Collaborator

@mrozentsvayg Anything left from your point of view ?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 14, 2025
@vflaux vflaux force-pushed the cf_improve_regional_hostname_1 branch from 750dffb to 3f6b944 Compare May 19, 2025 15:13
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 19, 2025
@vflaux vflaux force-pushed the cf_improve_regional_hostname_1 branch from 3f6b944 to 7a06b77 Compare May 19, 2025 15:44
@mloiseleur
Copy link
Collaborator

@vflaux Thanks for rebasing the PR. Do you think you can address review comments from @mrozentsvayg (like this one, for instance) ?

@vflaux vflaux force-pushed the cf_improve_regional_hostname_1 branch from 7a06b77 to 5475651 Compare May 20, 2025 08:37
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 20, 2025
@vflaux
Copy link
Contributor Author

vflaux commented May 20, 2025

@mloiseleur I moved the remaining functions to the dedicated file cloudflare_regional.go as requested.

@mloiseleur
Copy link
Collaborator

@mrozentsvayg Anything left from your point of view ?

@mrozentsvayg
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@mrozentsvayg: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mloiseleur
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivankatliarchuk, mloiseleur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 23, 2025
@mloiseleur
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 23, 2025
@k8s-ci-robot k8s-ci-robot merged commit 7c08814 into kubernetes-sigs:master May 23, 2025
14 of 15 checks passed
@vflaux vflaux mentioned this pull request Jun 21, 2025
Merged
3 tasks
@vflaux vflaux deleted the cf_improve_regional_hostname_1 branch July 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloiseleur mloiseleur Awaiting requested review from mloiseleur

@szuecs szuecs Awaiting requested review from szuecs

2 more reviewers

@mrozentsvayg mrozentsvayg mrozentsvayg left review comments

@ivankatliarchuk ivankatliarchuk ivankatliarchuk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@ivankatliarchuk ivankatliarchuk

@mloiseleur mloiseleur

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vflaux @k8s-ci-robot @ivankatliarchuk @mloiseleur @mrozentsvayg