Warning for “*” label still emitted by FindZone() after fix in #5685 #5706
Description
What happened:
After the merge of PR #5685 , the warning log for labels containing the * character (e.g., *.example.com) was resolved in some parts of the codebase by updating the IDNA profile. However, provider.ZoneIDName.FindZone() still uses the old IDNA conversion logic, which continues to emit a warning like:
Failed to convert label “*” of hostname “*.example.com” to its Unicode form: idna: disallowed rune U+002A
What you expected to happen:
Since the warning for * was intentionally suppressed in #5685 by adjusting the IDNA profile, I expected the same behavior to be applied consistently across the codebase, including in FindZone().
How to reproduce it (as minimally and precisely as possible):
Use a domain like *.example.com in a test or real configuration and observe that FindZone() still logs a warning due to the * character.
Anything else we need to know?:
It’s possible that the omission of FindZone() from the changes in #5685 was intentional, but it seems more likely to have been missed. To help clarify, I’ve submitted a small PR to address the remaining use of the outdated IDNA logic, in case the fix is desired: #5705
Happy to adjust or close the PR depending on whether this behavior is intentional or not.
Environment:
- External-DNS version (use
external-dns --version):latest main(post-fix(endpoint): domains handling with idna #5685, pre-release) - DNS provider: Original log was observed when using CloudDNS
- Others: N/A