removes policy action, adds bucketaccessinfo #47
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: krishchow The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/XXL
| // +optional | ||
| metav1.ObjectMeta `json:"metadata,omitempty"` | ||
|
|
||
| S3 *S3BucketAccessInfo `json:"s3,omitempty"` |
|
Does this needs to be coupled with corresponding changes to other COSI repos? |
|
Yes, that's correct! There will be another PR shortly for the Spec, followed by later changes for the other components. |
| Credentials string `json:"credentials,omitempty"` | ||
| Certificates string `json:"certificates,omitempty"` | ||
| SignatureVersion S3SignatureVersion `json:"signatureVersion,omitempty"` | ||
| } |
There was a problem hiding this comment.
I thought we are going to remove "SignatureVersion" and "Certificates"?
Code refactoring to make sure Buckets abd BucketAccess Add works corr…
added cloudbuiild.yaml
Code refactoring to make sure Buckets abd BucketAccess Add works corr…
added cloudbuiild.yaml
Add BlaineEXE to the owners file
4 participants
as above, this PR removes the policyActionConfig map in the API, and it adds the new bucketAccesssInfo struct which is part of the COSI downwards API.