feat: Update functions used by initialize function in UpdateRun controller to use interfaces #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arvindthiru
changed the title
Arvindthiru
changed the title
Arvindthiru
changed the title
Arvindthiru
force-pushed
the
stagedUpdateRunImpl
branch
from
5ca8a14 to
7abbf8c
Compare
Signed-off-by: Arvind Thirumurugan <[email protected]>
Arvindthiru
force-pushed
the
stagedUpdateRunImpl
branch
from
de06a31 to
1df8fc2
Compare
Signed-off-by: Arvind Thirumurugan <[email protected]>
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
jwtty
reviewed
Oct 3, 2025
added 3 commits
October 3, 2025 12:52
Signed-off-by: Arvind Thirumurugan <[email protected]>
Signed-off-by: Arvind Thirumurugan <[email protected]>
Signed-off-by: Arvind Thirumurugan <[email protected]>
jwtty
approved these changes
Oct 3, 2025
| ctx context.Context, | ||
| updateRun *placementv1beta1.ClusterStagedUpdateRun, | ||
| updateRun placementv1beta1.UpdateRunObj, | ||
| ) ([]*placementv1beta1.ClusterResourceBinding, []*placementv1beta1.ClusterResourceBinding, error) { |
There was a problem hiding this comment.
I assume the returned bindings will be changed to interface later?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
Special notes for your reviewer
Verifed E2Es by running them locally,