Skip to content

test: add integration tests for work applier exponential backoff behavior #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 22, 2025
Merged

test: add integration tests for work applier exponential backoff behavior #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
56b9f33
Added more tests
michaelawyu Aug 14, 2025
c157df8
Merge branch 'main' into test/work-applier-backoff-integration-tests
michaelawyu Aug 25, 2025
bea33e6
Minor fixes
michaelawyu Aug 25, 2025
1e2aa61
Merge branch 'main' into test/work-applier-backoff-integration-tests
michaelawyu Sep 2, 2025
5a49a95
Merge branch 'main' into test/work-applier-backoff-integration-tests
michaelawyu Sep 8, 2025
5db0b06
Minor fixes
michaelawyu Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,8 @@ test: manifests generate fmt vet local-unit-test integration-test## Run tests.
## workaround to bypass the pkg/controllers/workv1alpha1 tests failure
## rollout controller tests need a bit longer to complete, so we increase the timeout
##
# Set up the timeout parameters as some of the test lengths have exceeded the default 10 minute mark.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is the timeout set in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ryan! A previous PR has already set the timeout to 20 mins, so the changes have been absolved.

Copy link
Member Author

@michaelawyu michaelawyu Sep 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is 10 minutes, #182 has set it to 20 minutes and got merged before this PR

# TO-DO (chenyu1): enable parallelization for single package integration tests.
.PHONY: local-unit-test
local-unit-test: $(ENVTEST) ## Run tests.
export CGO_ENABLED=1 && \
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/workapplier/availability_tracker_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,7 +1013,7 @@ func TestTrackInMemberClusterObjAvailabilityByGVR(t *testing.T) {
// TestTrackInMemberClusterObjAvailability tests the trackInMemberClusterObjAvailability method.
func TestTrackInMemberClusterObjAvailability(t *testing.T) {
ctx := context.Background()
workRef := klog.KRef(memberReservedNSName, workName)
workRef := klog.KRef(memberReservedNSName1, workName)

availableDeploy := deploy.DeepCopy()
availableDeploy.Status = appsv1.DeploymentStatus{
Expand Down
Loading
Loading