Keyboard score entry #142
Open
Keyboard score entry #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was skipping rows 1-9 because keyboardFlag was 0, but worked anyway as expected. Doing a full read when detecting anyway.
|
Added detection at bootup with a toggle that flips on disconnection |
| // build / compress nametables | ||
|
|
||
| console.time('nametables'); | ||
| process.env['GYM_FLAGS'] = compileFlags.join(' '); |
| `); | ||
|
|
||
| if (process.env['GYM_FLAGS']?.match(/-D KEYBOARD=1/)) { | ||
| drawTiles(extra, lookup, "KEYBOARD", 32 * 15 + 6); |
There was a problem hiding this comment.
I guess this is not always correct and depends on mode quantity
There was a problem hiding this comment.
Yeah. A comment may be useful because of that. It's a placeholder until the next menu.
There was a problem hiding this comment.
we could potentially load some asm variables in this nametable bit... I'll have a think
Co-authored-by: Kirjava <[email protected]>
zohassadar
force-pushed
the
keyboard_score_entry
branch
from
c8c8a72 to
6f72aa2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the hard drop test to fail when the keyboard flag is enabled, but it passes when the changes in #135 are applied