-
Notifications
You must be signed in to change notification settings - Fork 19.6k
Version bump 3.11.1 #21535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump 3.11.1 #21535
Conversation
Also update error message which was inaccurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @rtg0795, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily updates the Keras library version to 3.11.1
. Additionally, it includes a targeted fix within the saving mechanism to ensure Operation
objects are correctly processed, which is crucial for robust model serialization and deserialization.
Highlights
- Version Update: The Keras library version has been incremented from
3.11.0
to3.11.1
. - Saving Library Enhancement: The
get_attr_skipset
function inkeras/src/saving/saving_lib.py
has been updated to properly recognize and handleOperation
objects. This includes adjusting a conditional check fromif
toelif
and extending the list of accepted object types in the validation error message to includeOperation
.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request bumps the package version to 3.11.1 and includes two bug fixes in keras/src/saving/saving_lib.py
. The first change corrects an if/elif
logic flow, and the second updates an error message to include a missing valid type. The code changes are sound and improve the overall quality.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## r3.11 #21535 +/- ##
=======================================
Coverage 82.72% 82.72%
=======================================
Files 567 567
Lines 56264 56264
Branches 8797 8797
=======================================
Hits 46544 46544
Misses 7562 7562
Partials 2158 2158
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
0e11071
into
keras-team:r3.11
Patch release with a small fix