Skip to content

Conversation

rtg0795
Copy link
Collaborator

@rtg0795 rtg0795 commented Jul 31, 2025

Patch release with a small fix

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @rtg0795, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily updates the Keras library version to 3.11.1. Additionally, it includes a targeted fix within the saving mechanism to ensure Operation objects are correctly processed, which is crucial for robust model serialization and deserialization.

Highlights

  • Version Update: The Keras library version has been incremented from 3.11.0 to 3.11.1.
  • Saving Library Enhancement: The get_attr_skipset function in keras/src/saving/saving_lib.py has been updated to properly recognize and handle Operation objects. This includes adjusting a conditional check from if to elif and extending the list of accepted object types in the validation error message to include Operation.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the package version to 3.11.1 and includes two bug fixes in keras/src/saving/saving_lib.py. The first change corrects an if/elif logic flow, and the second updates an error message to include a missing valid type. The code changes are sound and improve the overall quality.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jul 31, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jul 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.72%. Comparing base (7bf852c) to head (e0d0c1c).

Additional details and impacted files
@@           Coverage Diff           @@
##            r3.11   #21535   +/-   ##
=======================================
  Coverage   82.72%   82.72%           
=======================================
  Files         567      567           
  Lines       56264    56264           
  Branches     8797     8797           
=======================================
  Hits        46544    46544           
  Misses       7562     7562           
  Partials     2158     2158           
Flag Coverage Δ
keras 82.53% <100.00%> (ø)
keras-jax 63.93% <100.00%> (ø)
keras-numpy 58.41% <100.00%> (ø)
keras-openvino 34.56% <50.00%> (ø)
keras-tensorflow 64.35% <100.00%> (ø)
keras-torch 63.98% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@divyashreepathihalli divyashreepathihalli merged commit 0e11071 into keras-team:r3.11 Jul 31, 2025
12 of 13 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants