Skip to content

Conversation

aabernich
Copy link

I added the OpenVINO backend support for the NumPy operation argmin and argmax which should close issue #29011.

Copy link

google-cla bot commented Feb 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@fchollet
Copy link
Collaborator

@rkazants please review!

@rkazants
Copy link
Contributor

@aabernich, please figure out why the precommit tests are not run for your PR.

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 80.10%. Comparing base (e045b6a) to head (6598d9d).
Report is 23 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/numpy.py 0.00% 32 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #20917      +/-   ##
==========================================
- Coverage   82.26%   80.10%   -2.16%     
==========================================
  Files         561      561              
  Lines       52693    53024     +331     
  Branches     8146     8215      +69     
==========================================
- Hits        43347    42477     -870     
- Misses       7344     8587    +1243     
+ Partials     2002     1960      -42     
Flag Coverage Δ
keras 79.92% <0.00%> (-2.15%) ⬇️
keras-jax 64.08% <0.00%> (-0.16%) ⬇️
keras-numpy 58.88% <0.00%> (-0.12%) ⬇️
keras-openvino ?
keras-tensorflow 64.56% <0.00%> (-0.28%) ⬇️
keras-torch 64.14% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hertschuh
Copy link
Collaborator

This was done in #21060

@hertschuh hertschuh closed this Aug 8, 2025
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Closed/Rejected in PR Queue Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Closed/Rejected
Development

Successfully merging this pull request may close these issues.

6 participants