-
Notifications
You must be signed in to change notification settings - Fork 28
Add jupyterlite_ignore_contents
config, mapping to --ignore-contents
arg in JupyterLite build
#309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jupyterlite_ignore_contents
config, mapping to --ignore-contents
arg in JupyterLite build
#309
Conversation
…ts` arg to JupyterLite build
kwargs["stdout"] = subprocess.PIPE | ||
kwargs["stderr"] = subprocess.PIPE | ||
|
||
print(f'Command: {command}') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was helpful to me for debugging, happy to remove.
@martinRenou if you have a moment for this, it will be useful for our JupyterGIS docs build :) (I want to exclude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks.
Given your multiple PRs merged, I will give you rights to that repo , we need more maintainers! :D
kwargs["stdout"] = subprocess.PIPE | ||
kwargs["stderr"] = subprocess.PIPE | ||
|
||
print(f"[jupyterlite-sphinx] Command: {command}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'd agree to keep it.
Looking forward to helping out a bit :) |
Resolves #308