Skip to content

Conversation

mfisher87
Copy link
Collaborator

Resolves #308

kwargs["stdout"] = subprocess.PIPE
kwargs["stderr"] = subprocess.PIPE

print(f'Command: {command}')
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was helpful to me for debugging, happy to remove.

@mfisher87
Copy link
Collaborator Author

mfisher87 commented Aug 27, 2025

@martinRenou if you have a moment for this, it will be useful for our JupyterGIS docs build :) (I want to exclude .qgz files which can't be used in JupyterLite)

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

Given your multiple PRs merged, I will give you rights to that repo , we need more maintainers! :D

kwargs["stdout"] = subprocess.PIPE
kwargs["stderr"] = subprocess.PIPE

print(f"[jupyterlite-sphinx] Command: {command}")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'd agree to keep it.

@martinRenou martinRenou added the enhancement New feature or request label Sep 5, 2025
@martinRenou martinRenou merged commit a9b1502 into jupyterlite:main Sep 5, 2025
5 of 6 checks passed
@mfisher87
Copy link
Collaborator Author

Given your multiple PRs merged, I will give you rights to that repo , we need more maintainers! :D

Looking forward to helping out a bit :)

@mfisher87 mfisher87 deleted the support-ignore-contents-arg branch September 5, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support --ignore-contents through sphinx config
2 participants