feat(tickets): add way to track changes #1102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@crowlKats 3 months since this pr has been opened can I have review ? |
crowlKats
reviewed
Oct 8, 2025
| <div> | ||
| The ticket was submitted. You can view it{" "} | ||
| <a href={`/ticket/${ticket.value!.id}`} class="link"> | ||
| <a href={`/ticket/${ticket.value!}`} class="link"> |
crowlKats
reviewed
Oct 8, 2025
Comment on lines
+41
to
+48
| let id = match req.param_uuid("id") { | ||
| Ok(id) => id, | ||
| Err(_) => { | ||
| return Err(ApiError::MalformedRequest { | ||
| msg: "Invalid ID".into(), | ||
| }) | ||
| } | ||
| }; |
crowlKats
reviewed
Oct 8, 2025
Comment on lines
+51
to
+54
| let db = match req.data::<Database>() { | ||
| Some(db) => db, | ||
| None => return Err(ApiError::InternalServerError), | ||
| }; |
crowlKats
reviewed
Oct 8, 2025
| Ok(Some(ticket)) => ticket, | ||
| Ok(None) => return Err(ApiError::TicketNotFound), | ||
| Err(_) => return Err(ApiError::InternalServerError), | ||
| }; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a way to track changing state of a tickets
PR Checklist
conventional commits
description of the changes and rason behind them.
recording of the changes.
If it affect colors, please include screenshots/recording in both
light and dark mode.
And if changing dababase queries, be sure you have ran
sqlx prepareand committed the changes in the
.sqlxdirectory.