Add conversion for SharedArrayBuffer
#50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of whatwg/webidl#1311, WebIDL has its own
SharedArrayBuffer
type. I added aconversions.SharedArrayBuffer
function to properly recognize this.I also noticed that this conversion was incorrectly throwing an error, so I fixed that:
Questions:
[AllowShared] ArrayBuffer
. However, that's no longer supported: you can only apply[AllowShared]
on a buffer view type. For now, I've kept theallowShared
option around inconversions.ArrayBuffer
, but perhaps we should remove it instead?