Build: Make browser tests correctly run on multiple jQuery versions #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgol
added a commit
to mgol/jquery-migrate
that referenced
this pull request
Apr 15, 2025
There was a typo in `jtr-local.yml`, making the runs using it load with a huge query string containing all the jQuery versions listed joined. This all meant only one jQuery version was actually tested. Ref jquerygh-575
There was a typo in `jtr-local.yml`, making the runs using it load with a huge query string containing all the jQuery versions listed joined. Also, only IE and Safari runs even tried to use this config - the default run was not even reading the BROWSERS env variable. This all meant only one jQuery version was actually tested. Ref jquerygh-576
mgol
added
the
Discuss in Meeting
timmywil
approved these changes
Apr 28, 2025
timmywil
removed
the
Discuss in Meeting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a typo in
jtr-local.yml, making the runs using it load with a hugequery string containing all the jQuery versions listed joined.
Also, only IE and Safari runs even tried to use this config - the default run
was not even reading the BROWSERS env variable.
This all meant only one jQuery version was actually tested.
Ref gh-576