Support BYSETPOS for recurring monthly events #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjsir911
commented
Mar 10, 2025
Comment on lines
+99
to
+101
| : bysetpos.flatMap((n) => | ||
| byweekday.map((weekday: Weekday) => weekday.nth(n)) | ||
| ) |
There was a problem hiding this comment.
it's probably important to note that this is not compliant with the BYSETPOS spec but is good enough, BYSETPOS specifying that it specifies constraints to the "nth" possible option every iteration, so this would be wrong when including multiple weekdays since it's not taking to account that multiple weekdays happen.
|
Hi, you may want to look at rrule-temporal, it has full RFC-5545 and toText support: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436
Thanks for contributing to
rrule!To submit a pull request, please verify that you have done the following:
mastercommitaddressing