-
Notifications
You must be signed in to change notification settings - Fork 2k
Fixes #13472 - Support multiple directories to be scanned by deployment-scanner. #13605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #13472 - Support multiple directories to be scanned by deployment-scanner. #13605
Conversation
…nt-scanner. * Updated jetty-deployment-scanner.xml to support a CVS list of directories. * Updated documentation. * Added tests, and cleaned up XmlConfigurationTest. Signed-off-by: Simone Bordet <[email protected]>
Tested with locally built (69c94c9). Thanks! |
@pzygielo thanks for the feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbordet If we support multiple directories, do we handle a foo.war
in one directory and a foo.xml
in another and a foo.properties
in yet another? Should we?
Should we support property files in a deployment directory that apply to all webapps from that directory?
@gregw I think technically it would be possible to have
I don't think so. If you mean a single Multiple directories may be used for different environments, but I can also see multiple directories used for multiple web application sources (e.g. I would just leave it to the users to not make it too complicated; we just offer multiple directories. |
#tag::documentation[] | ||
## The web application deploy directory name (relative to $JETTY_BASE) | ||
## The web application deploy directory name, or a comma-separated | ||
## list of directories (relative to $JETTY_BASE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this true? Must they be relative to $JETTY_BASE
? The javadoc on XmlConfiguration.csvSplitAndResolvePaths
says it accepts relative or absolute paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I clarified the module comment, in this file as well as in other files.
Signed-off-by: Simone Bordet <[email protected]>
Uh oh!
There was an error while loading. Please reload this page.