Re-enable HttpChannelEventTest and port to ee9 #12477
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
gregw
requested changes
Nov 8, 2024
| @Override | ||
| public void onRequestFailure(Request request, Throwable failure) | ||
| { | ||
| //TODO never called |
There was a problem hiding this comment.
The onRequestFailure and onComplete methods will never be called for a bad request in jetty-12, as that is determined in core and thus we do not know what context the bad request would have gone to.
So this test is invalid and we should update the javadoc of the listener class to say as much
| @Override | ||
| public void onResponseFailure(Request request, Throwable failure) | ||
| { | ||
| //TODO this is never called |
There was a problem hiding this comment.
This could be a bug. I see no reason that a response failure within a context cannot be notified like this.
Further analysis required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port
HttpChannelEventTesttoee9and re-enable it.