-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
Website: Fix link for migration to jest 28 #15783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for jestjs ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
babel-jest
babel-plugin-jest-hoist
babel-preset-jest
create-jest
@jest/diff-sequences
expect
@jest/expect-utils
jest
jest-changed-files
jest-circus
jest-cli
jest-config
@jest/console
@jest/core
@jest/create-cache-key-function
jest-diff
jest-docblock
jest-each
@jest/environment
jest-environment-jsdom
@jest/environment-jsdom-abstract
jest-environment-node
@jest/expect
@jest/fake-timers
@jest/get-type
@jest/globals
jest-haste-map
jest-jasmine2
jest-leak-detector
jest-matcher-utils
jest-message-util
jest-mock
@jest/pattern
jest-phabricator
jest-regex-util
@jest/reporters
jest-resolve
jest-resolve-dependencies
jest-runner
jest-runtime
@jest/schemas
jest-snapshot
@jest/snapshot-utils
@jest/source-map
@jest/test-result
@jest/test-sequencer
@jest/transform
@jest/types
jest-util
jest-validate
jest-watcher
jest-worker
pretty-format
commit: |
/easyCLA |
I assume the failing tests have nothing to do with me, but there are a lot more failures compared to the latest commit on main, so I'm not sure what's up with that: fe7f28c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
Replaces the broken migration link referenced in the jest 28 announcement blog post with a link that still works: https://jest-archive-august-2023.netlify.app/docs/28.x/upgrading-to-jest28/
While the equivalent link in the jest 29 announcement post is not broken (yet), I imagine that it will probably become broken when jest 31 comes out, like happened with the jest 28 migration link. To avoid this, I updated its link to point to the same August 2023 archive subdomain on Netlify I used for the jest 28 link.
Test plan
I did not test this locally, because it's quite hard to imagine that it would not work. If the maintainers do not share my confidence, I would be happy to do so when I get the chance.I have verified that the changes were made as intended using the Netlify Deploy Preview.