Frontend: Fix notification count of TRUE
#5391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`update_ticker_count` used to use STORAGE_KEY_STREAM to get the number of notifications which is a boolean value, now it uses STORAGE_KEY_NOTIF_COUNT which is an integer
Not sure if this is necessary as I think it should always be present in storage, but just in case it isn't
ChunkyProgrammer
approved these changes
Jul 19, 2025
syeopite
changed the title
TRUETRUE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the number of notifications can be displayed as
TRUErather thanthe actual amount of notifications.
See here:
The issue comes from the
update_ticker_countfunction innotifications.js. It uses the storage valueSTORAGE_KEY_STREAMwhich is a boolean value rather thanSTORAGE_KEY_NOTIF_COUNTwhich is the actual number of notifications.The issue doesn't always occur because when you refresh the page, the new HTML returned by the server returns the correct amount of notifications, it's only an issue if you receive a new notification while watching a video.