Skip to content

Fix MSVC Ninja build by adding /Zc:inline on MSVC #7335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix MSVC Ninja build by adding /Zc:inline on MSVC #7335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c65f99
Fix MSVC Ninja build by adding /Zc:inline on MSVC
patrikhuber Sep 15, 2025
6419fe1
Updated CHANGELOG.md
patrikhuber Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@
- Exposed `get_plotly_fig` and modified `draw_plotly` to return the `Figure` it creates. (PR #7258)
- Fix build with librealsense v2.44.0 and upcoming VS 2022 17.13 (PR #7074)
- Fix `deprecated-declarations` warnings when compiling code with C++20 standard (PR #7303)
- Fix linker error "library limit of 65535 objects exceeded" with Ninja generator on MSVC (PR #7335)

## 0.13

Expand Down
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -498,6 +498,10 @@ if(WIN32)
#
# See: https://github.com/tensorflow/tensorflow/pull/10962
add_compile_options("$<$<COMPILE_LANGUAGE:CXX>:/bigobj;/Ob2>")
# MSBuild adds /Zc:inline by default, but it needs to be added explicitly for other generators (e.g. Ninja),
# for Open3D to compile (the linker fails otherwise with a "fatal error LNK1189: library limit of 65535
# objects exceeded"). /Zc:inline will remove unreferenced data and functions from object files.
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:/Zc:inline>)
endif()
if (STATIC_WINDOWS_RUNTIME)
set(CMAKE_MSVC_RUNTIME_LIBRARY "MultiThreaded$<$<CONFIG:Debug>:Debug>")
Expand Down
Loading